-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readouts and calo cell position #7
Comments
Since edm4hep does not have two different types for Calo hits with / without position I don't think a separate algorithm like this makes sense. Looking at the workflow you linked, I think the positon should be set directly in |
the segmentation classes could be modified and calculate the good position, without relying on the G4 volume position (which is what causes the position stored with saveCells to be crappy), but anyway now we have the CreatePositionedCaloCells alg that is like CreateCaloCells but uses a handle to a positioning tool to position the cells so maybe we can close this issue @BrieucF ? |
Agreed |
LAr calo cell positions used to be derived in several step, relying on CreateVolumePositions and two different readouts (see e.g. runCaloSim.py). This feature should be recovered and/or refactored.
The text was updated successfully, but these errors were encountered: