Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readouts and calo cell position #7

Closed
BrieucF opened this issue May 27, 2021 · 3 comments
Closed

Readouts and calo cell position #7

BrieucF opened this issue May 27, 2021 · 3 comments

Comments

@BrieucF
Copy link
Contributor

BrieucF commented May 27, 2021

LAr calo cell positions used to be derived in several step, relying on CreateVolumePositions and two different readouts (see e.g. runCaloSim.py). This feature should be recovered and/or refactored.

@vvolkl
Copy link
Member

vvolkl commented May 28, 2021

Since edm4hep does not have two different types for Calo hits with / without position I don't think a separate algorithm like this makes sense. Looking at the workflow you linked, I think the positon should be set directly in CreateCaloCells. I'll try to refactor the code into a tool and add it there

@giovannimarchiori
Copy link
Contributor

the segmentation classes could be modified and calculate the good position, without relying on the G4 volume position (which is what causes the position stored with saveCells to be crappy), but anyway now we have the CreatePositionedCaloCells alg that is like CreateCaloCells but uses a handle to a positioning tool to position the cells so maybe we can close this issue @BrieucF ?

@BrieucF
Copy link
Contributor Author

BrieucF commented Nov 6, 2024

Agreed

@BrieucF BrieucF closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants