expanded version of CreateCaloCells that also add proper cell positions #100
Conversation
giovannimarchiori
changed the title
…s. Include also hcal endcap in test, and move to new hcal positioning tool for hcal barrel)
…unning over particle gun samples
|
Hi @giovannimarchiori, would this algorithm work also for FCChh? |
|
Hi @kjvbrt - definitely. I guess you are suggesting to move the files to RecCalorimeter, like CreateCaloCells? |
|
Yes |
RecFCCeeCalorimeter/src/components/CreatePositionedCaloCells.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| // Copy over the CellIDEncoding string from the input collection to the output collection | ||
| auto hitsEncoding = m_hitsCellIDEncoding.get_optional(); | ||
| if (!hitsEncoding.has_value()) { |
There was a problem hiding this comment.
Is this worthy of crashing, can't this be just a warning?
There was a problem hiding this comment.
it's exactly as in CreateCaloCells (
). Without encoding the input cells can't be properly decoded in terms of layer and theta/eta/phi id which is needed for the various tools (positioning, calibration, ..). I would leave it like that, if you agree I will resolve the conversation
|
Hi @kjvbrt , I implemented your comments and answered one question. I reran the tests locally and also in GitHub and they ran fine |
|
Hi @giovannimarchiori, nice :) |
This PR tries to tackle #7
The position added to the cells by CreateCaloCells uses volume ID + segmentation to calculate the position of the cells, but it lacks the z information (maybe the code could have worked but the part that retrieves the z information from the segmentation does not seem to be implemented, and would depend on the segmentation type).
Since we have already tools that translates cellID into position, I wrote a CreatePositionedCaloCells algorithm that works exactly like CreateCaloCells but for the cell position uses the positioning tool to calculate it and save it into the cell.
I think this tool could probably supersede both CreateCaloCells and CreateCaloCellPositionsFCCee, but for the moment I just added a new tool and left there the old ones so that nobody is affected.
The new tool is scheduled in the test being run automatically and is used systematically instead of CreateCaloCells and CreateCaloCellPositionsFCCee.
In this PR I also enabled in the test script the hcal endcap digisation and the new positioning tool for hcal barrel and endcap that were not included in the tests so far.
I will make some tests in the coming days to check that the output is unchanged by switching to the new tool but the review of the code structure can proceed in parallel.