Do not use GaudiAlg #101
Merged
Do not use GaudiAlg #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like something broke |
|
Let's merge this after #102 and then check CI again but in principle this is ready and all the tests are passing except the two en #102. In this case many changes were needed, and adding mutable means that most of the algorithms are not ready for multithreading but this has probably to be checked on an algorithm by algorithm basis. |
- Change headers and add EventContext in algorithms not to use GaudiAlg - Replace `GaudiTool` with `AlgTool`
|
Thanks Juan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes needed not to use GaudiAlg, which will be removed (maybe soon) in Gaudi.