Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools for the implmentation of noise for ALLEGRO v3 #107

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

zwu0922
Copy link
Contributor

@zwu0922 zwu0922 commented Aug 19, 2024

Code developed under the following nightly version:
source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh -r 2024-07-31

Update:

  1. Set the default segmentation in "CreateCaloCells" to "ModuleThetaMerged".
  2. Add new barrel geometry tool matching the segmentation of ALLEGRO v3.
  3. Add a steering file and a temporary test command (to be moved to ddsim+k4run, since the test is ALLEGRO specific)

Caution: The noise filter is not ready yet.

@giovannimarchiori
Copy link
Contributor

I think we can merge the PR as is and I will fix a few little issues in a subsequent PR:

  • hardcoded systemID value
  • nonworking code to be removed
  • move the tool to RecFCCeeCalorimeter where other "vsTheta" tools live
  • revert the defaults of CreateCaloCells (these are all configurables that we can set in python to whatever it's appropriate for FCC-ee, but let's not modify the defaults)
  • move the test scripts to ddsim+k4run

@giovannimarchiori giovannimarchiori merged commit af83315 into HEP-FCC:main Sep 13, 2024
2 of 5 checks passed
kjvbrt pushed a commit that referenced this pull request Sep 17, 2024
* move TubeLayerModuleThetaCaloTool to RecFCCeeCalorimeter. Avoid hardcoding systemID in C++, pass it via configurables. Remove test based on legacy scripts with k4run

* add noise and noise-filtering to automatic test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants