Fixes for tutorials #17
Conversation
| StatusCode CaloTowerTool::finalize() { | ||
|
|
||
|
|
||
| for (auto& towerInMap : m_cellsInTowers) { |
There was a problem hiding this comment.
Hi Valentin, great! Do you think it will fix this as well: #13 ?
There was a problem hiding this comment.
Hi Brieuc, possibly; I was checking this with the joboptions here: https://github.com/HEP-FCC/k4RecCalorimeter/tree/main/RecFCCeeCalorimeter/tests/options (slightly fixed, will add those here too).
Which job did you see your issue with?
There was a problem hiding this comment.
Here is a config that I froze when I reported the problem: /afs/cern.ch/user/b/brfranco/work/public/Fellow/FCCSW/dummy_releases/Mark_Test2/LAr_scripts/FCCSW_ecal/reproduceSegFault.py
There was a problem hiding this comment.
Thanks, yes, seems like this is working with this branch, although you should still check the output!
…t processing since CreateCaloCells now takes SimCalorimeterHits as input, but this algo is still used to add noise to CalorimeterHits. Should be refactored/templated in the future.
vvolkl
force-pushed
the
tutorial-fixes
branch
from
3cde943
to
1910d4f
Compare
|
The link between cells and clusters works now as expected. See here: #13 (comment) |
No description provided.