Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for running standalone HCal #34

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

mmlynari
Copy link
Contributor

fix for running standalone HCal, otherwise, the code always looks for ECal

fix for running standalone HCal, otherwise, the code always looks for ECal
@kjvbrt
Copy link
Contributor

kjvbrt commented Feb 13, 2023

What is the intended use of the m_useHalfTower variable?

Is it to ignore cells from the layers above 3? link

But the code will ignore all cells after first cell with layerID larger than 3 (including the current cell).

Also, 3 is a magic number. Better to have it as a configurable value.

@mmlynari
Copy link
Contributor Author

mmlynari commented Feb 14, 2023

my understanding was that this was an option that was used for some FCC-hh studies. I do not think we are currently using it. Maybe @faltovaj or @BrieucF can comment if this option can be of any use in the future or it can be removed

@BrieucF
Copy link
Contributor

BrieucF commented Mar 2, 2023

I'll merge and fix m_useHalfTower in another PR

@BrieucF BrieucF merged commit 89a764d into HEP-FCC:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants