Add cell filtering functionalities #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrieucF
commented
Mar 16, 2023
BrieucF
commented
- Add the possibility to filter cells without adding noise
- Add the possibility to filter cells based on energy absolute value
kjvbrt
reviewed
Mar 16, 2023
| @@ -43,7 +43,7 @@ StatusCode CreateCaloCells::initialize() { | |||
| } | |||
| } | |||
| // Cell noise tool | |||
| if (m_addCellNoise) { | |||
| if (m_addCellNoise || m_filterCellNoise) { | |||
There was a problem hiding this comment.
Will this try to retrieve noiseTool even if you will just filter based on absolute value?
There was a problem hiding this comment.
Yes, filtering on absolute value still requires noiseTool link
BrieucF
changed the title
|
Now that the cell filtering functionality is not fully bounded to the noise application anymore, one could think of factorizing it as a separated tool that would be called by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.