Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crosstalk neighbour class #69

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Add crosstalk neighbour class #69

merged 7 commits into from
Apr 23, 2024

Conversation

zwu0922
Copy link
Contributor

@zwu0922 zwu0922 commented Mar 21, 2024

Added two more files "CreateFCCeeCaloXTalkNeighbours.cpp" and "CreateFCCeeCaloXTalkNeighbours.h" in order to loop over the cells of ALLERGRO ECAL barrel and generate a mapping of crosstalk neighbours.

No change is introduced to the existing part of the software package.

Example:
https://github.com/zwu0922/LAr_scripts/blob/main/FCCSW_ecal/xtalk_neighbours_theta.py
In order to produce the list of crosstalk neighbours and coefficients, run
fccrun xtalk_neighbours_theta.py

@kjvbrt
Copy link
Contributor

kjvbrt commented Apr 5, 2024

Hi @zwu0922, thanks for the PR :) I was able to compile it locally with the changes in key4hep/k4geo#331.

Can you add test steering or a link to the example usage?

@zwu0922
Copy link
Contributor Author

zwu0922 commented Apr 5, 2024

Hi @zwu0922, thanks for the PR :) I was able to compile it locally with the changes in key4hep/k4geo#331.

Can you add test steering or a link to the example usage?

Yes, I added an example usage. Please find the beginning of this thread.

@BrieucF
Copy link
Contributor

BrieucF commented Apr 12, 2024

Hi Zhibo, thanks for this!

I think what Juraj meant is to add a minimal Gaudi steering file here: RecFCCeeCalorimeter/tests/options and to add it to the automatic tests as done e.g. here: https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecFCCeeCalorimeter/CMakeLists.txt#L42-L46 . Can you do that?

@zwu0922
Copy link
Contributor Author

zwu0922 commented Apr 12, 2024

Hi Zhibo, thanks for this!

I think what Juraj meant is to add a minimal Gaudi steering file here: RecFCCeeCalorimeter/tests/options and to add it to the automatic tests as done e.g. here: https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecFCCeeCalorimeter/CMakeLists.txt#L42-L46 . Can you do that?

Hi Brieuc, thanks for the explanation. I tentatively added a steering file and modified the CMakeLists.txt in a new commit. Will this be sufficient?

@BrieucF
Copy link
Contributor

BrieucF commented Apr 12, 2024

The test is failing because we have to merge first the k4geo PR. Will trigger the test again when it is merge

@BrieucF BrieucF merged commit 255127a into HEP-FCC:main Apr 23, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants