-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crosstalk neighbour class #69
Conversation
Hi @zwu0922, thanks for the PR :) I was able to compile it locally with the changes in key4hep/k4geo#331. Can you add test steering or a link to the example usage? |
RecFCCeeCalorimeter/src/components/CreateFCCeeCaloXTalkNeighbours.cpp
Outdated
Show resolved
Hide resolved
Yes, I added an example usage. Please find the beginning of this thread. |
Hi Zhibo, thanks for this! I think what Juraj meant is to add a minimal Gaudi steering file here: |
Hi Brieuc, thanks for the explanation. I tentatively added a steering file and modified the CMakeLists.txt in a new commit. Will this be sufficient? |
The test is failing because we have to merge first the k4geo PR. Will trigger the test again when it is merge |
Added two more files "CreateFCCeeCaloXTalkNeighbours.cpp" and "CreateFCCeeCaloXTalkNeighbours.h" in order to loop over the cells of ALLERGRO ECAL barrel and generate a mapping of crosstalk neighbours.
No change is introduced to the existing part of the software package.
Example:
https://github.com/zwu0922/LAr_scripts/blob/main/FCCSW_ecal/xtalk_neighbours_theta.py
In order to produce the list of crosstalk neighbours and coefficients, run
fccrun xtalk_neighbours_theta.py