Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shapeParameters in MVA calibration #77

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

giovannimarchiori
Copy link
Contributor

This PR adds to the MVA calibration algorithm the possibility to read the energy fractions per layer directly from the shapeParameters of the input clusters (if available) rather than recalculating them on the fly. It also shows how to save in output the shapeParameters of the input collections plus some extra parameters (in this case the raw energy of the cluster before the MVA calibration).

@giovannimarchiori
Copy link
Contributor Author

Usage example: very similar to before, just need to pass to the algorithm the string of the detector name used in the shapeParameters to label the energy fraction decorations, i.e. add the systemNames = ... row below:

calibrateCaloClusters = CalibrateCaloClusters("calibrateCaloClusters",
                                              inClusters="Augmented" + createClusters.clusters.Path,
                                              outClusters="Calibrated" + createClusters.clusters.Path,
                                              systemIDs=[4],
                                              systemNames=["EMB"],
                                              numLayers=[ecalBarrelLayers],
                                              firstLayerIDs=[0],
                                              readoutNames=[
                                                  ecalBarrelReadoutName],
                                              layerFieldNames=["layer"],
                                              calibrationFile="data/lgbm_calibration-CaloClusters-v03.onnx",
                                              OutputLevel=INFO
                                              )

@giovannimarchiori giovannimarchiori marked this pull request as draft April 18, 2024 09:11
…y were then divided by cluster energy by mistake
@giovannimarchiori giovannimarchiori marked this pull request as ready for review April 18, 2024 09:51
@kjvbrt kjvbrt merged commit d7a5d4c into HEP-FCC:main Apr 18, 2024
3 of 6 checks passed
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-20240418 branch July 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants