Consolidate tools handling noise #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specific segmentation class, improve naming of some methods
This was referenced Jul 19, 2024
…stNoiseTool and set it to false by default to avoid having to specify the list of offsets in python
The tests fail because they need this: key4hep/k4FWCore#214 |
kjvbrt
reviewed
Jul 25, 2024
kjvbrt
reviewed
Jul 25, 2024
| @@ -44,7 +44,7 @@ StatusCode TopoCaloNoisyCells::initialize() { | |||
| double readNoisyCells; | |||
| double readNoisyCellsOffset; | |||
| tree->SetBranchAddress("cellId", &readCellId); | |||
| tree->SetBranchAddress("noiseLevel", &readNoisyCells); | |||
| tree->SetBranchAddress("noiseLevel", &readNoisyCells); // would be better to call branch noiseRMS rather than noiseLevel | |||
There was a problem hiding this comment.
I am not sure, this would mean that the noise map files have to be regenerated changing name to the rms branch. I would be ok with that but don’t want to disrupt the user who have already noise files at hand. What do you and @BrieucF prefer?
There was a problem hiding this comment.
Yes, we can handle this in another PR
kjvbrt
reviewed
Jul 25, 2024
RecFCCeeCalorimeter/src/components/NoiseCaloCellsVsThetaFromFileTool.cpp
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate code of tools handling noise, improve readability, remove duplications, add tool to add noise to cells for fcc-ee.
Needs key4hep/k4FWCore#214