Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoSvc: Add constantAsString, EnableGeant4Geo, getDetector, deprecated lcdd #47

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Aug 30, 2023

BEGINRELEASENOTES

  • GeoSvc: add constantAsString implementation
  • GeoSvc: add "EnableGeant4Geo" to disable the creation of the Geant4Geometry if it is not needed
  • GeoSvc: add getDetector function, marking lcdd() as deprecated
  • Replaced use of lcdd() in all places
  • SimG4Interface: Removed IGeoSvc.h file, use k4Interface instead

ENDRELEASENOTES

This is part of key4hep/k4MarlinWrapper#27

@andresailer andresailer changed the title Add constantAsString and EnableGeant4Geo GeoSvc: Add constantAsString, EnableGeant4Geo, getDetector, deprecated lcdd Aug 30, 2023
@andresailer
Copy link
Contributor Author

@kjvbrt Please have a look at this

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 12, 2023

Hi @andresailer,

I'm getting crashes at m_runManager.Initialize();, when running tests locally at Alma9/nightly stack.

#6  0x00007fc6c0421281 in G4RunManagerKernel::DefineWorldVolume(G4VPhysicalVolume*, bool) () from /cvmfs/sw
-nightlies.hsf.org/key4hep/releases/2023-09-03/x86_64-almalinux9-gcc11.3.1-opt/geant4/11.1.2-brmbdz/lib64/l
ibG4run.so
#7  0x00007fc6c03ff823 in G4RunManager::InitializeGeometry() () from /cvmfs/sw-nightlies.hsf.org/key4hep/re
leases/2023-09-03/x86_64-almalinux9-gcc11.3.1-opt/geant4/11.1.2-brmbdz/lib64/libG4run.so
#8  0x00007fc6c03ff9b0 in G4RunManager::Initialize() () from /cvmfs/sw-nightlies.hsf.org/key4hep/releases/2
023-09-03/x86_64-almalinux9-gcc11.3.1-opt/geant4/11.1.2-brmbdz/lib64/libG4run.so
#9  0x00007fc6bb597d56 in SimG4Svc::initialize (this=0x36280d0) at /home/jsmiesko/Work/FCC/k4SimGeant4/SimG
4Components/src/SimG4Svc.cpp:72

The tests which are failing are testing magnetic field tools, failures occur either for IDEA-LAr and CLD. One of the failing tests:

SimG4Components/tests/options/magFieldFromMap.py

@andresailer
Copy link
Contributor Author

Hi @kjvbrt
Did you also update k4FWCore with the change in IGeoSvc?

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 12, 2023

Hi @andresailer,
I compiled branches addAccessor in both repos (k4FWCore first and after that k4SimGeant4)

@andresailer
Copy link
Contributor Author

Where is "k4simgeant4env.sh" supposed to be?

COMMAND bash -c "source k4simgeant4env.sh; k4run ${CMAKE_CURRENT_LIST_DIR}/tests/options/magFieldScanner.py"

Which is also used by that test in FCCDetectors.

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 12, 2023

k4simgeant4env.sh is in build directory, it's generated.

@andresailer
Copy link
Contributor Author

Thanks @kjvbrt
I was building everything together and that didn't create this file.
I found the offending IGeoSvc.h in this repository and removed it. Locally that test is passing now.

@kjvbrt kjvbrt merged commit 07b4981 into HEP-FCC:main Sep 12, 2023
0 of 2 checks passed
@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 12, 2023

great, merging.

@andresailer andresailer deleted the addAccessor branch September 12, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants