Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Allow Yes/No in addition to Y/N for booleans in transformations #1985

Closed
2 tasks
chouinar opened this issue May 10, 2024 · 0 comments · Fixed by #1986
Closed
2 tasks

[Task]: Allow Yes/No in addition to Y/N for booleans in transformations #1985

chouinar opened this issue May 10, 2024 · 0 comments · Fixed by #1986
Assignees
@chouinar
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@chouinar
Copy link
Collaborator

Summary

Its incredibly uncommon, but some very old data in the Oracle system stores booleans as the strings Yes/No instead of Y/N.

We should just consider those truthy as well.

Acceptance criteria

  • Updated transform logic
  • Updated tests
@chouinar chouinar added the project: grants.gov Grants.gov Modernization tickets label May 10, 2024
@chouinar chouinar added this to the Search API - ELT Implementation milestone May 10, 2024
@chouinar chouinar self-assigned this May 10, 2024
chouinar added a commit that referenced this issue May 10, 2024
@chouinar
[Issue #1985] Allow yes/no for transformed booleans
d35eb7b
@chouinar chouinar mentioned this issue May 10, 2024
Merged
chouinar added a commit that referenced this issue May 10, 2024
@chouinar
[Issue #1985] Allow yes/no for transformed booleans (#1986)
3f65a0b 
## Summary
Fixes #1985

### Time to review: __2 mins__

## Changes proposed
When handling transformations of booleans, allow `Yes` and `No` as valid
values in addition to `Y` and `N`.

## Context for reviewers
These new values are immensely uncommon, but there are a few rare
occurrences of them. Easier to just support them than work around in any
other way.

## Additional information
For example, in `TSYNOPSIS_HIST`, the count of values for the
cost_sharing bool:

```
No	971
N	60820
Y	13723
Yes	581
```
The non-history table does not have this value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chouinar chouinar

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #1985] Allow yes/no for transformed booleans HHS/simpler-grants-gov
1 participant
@chouinar