Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Fix Zip Slip Vulnerability #81

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/hl7/fhir/tools/publisher/WebMaker.java
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,11 @@ private void extractZip(String src, String dest) throws Exception {
String name = ze.getName();
if (name.endsWith(".html") || name.endsWith(".htm") || name.endsWith(".png") || name.endsWith(".css")) {
InputStream in = zf.getInputStream(ze);
OutputStream out = new FileOutputStream(dest+name);
final File zipEntryFile = new File(dest, name);
if (!zipEntryFile.toPath().normalize().startsWith(dest)) {
throw new RuntimeException("Bad zip entry");
}
OutputStream out = new FileOutputStream(zipEntryFile);

byte data[] = new byte[BUFFER];
int count;
Expand Down