Add gen_new_specification to the kernel. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Rob Arthan's "HOL Constant Definition Done Right". The tricky part is deciding how and where to implement the existing definitional rules that are theoretically subsumed by the new one.
in terms of the revised Thm.prim_specification. obviously this breaks anything that depended on Theory.new_specification, so the next job is to rework those things (and write a backwards-compatible version, but later in the build sequence because it needs pairs.)
Implement new_definition in terms of gen_prim_specification. Leave the existing new_specification in place. This plan of attack suggested by RDA. Have only touched the standard kernel, and none of the theories. Next steps would include updating the other kernels, implementing new_specification in terms of gen_new_specification (at some point after pairTheory), and removing uses of new_specification before pairTheory one by one if possible/desired...
in pairLib - should re-export elsewhere.
|
I'm happy in principle, but can you:
Thanks |
Conflicts: src/pair/src/pairLib.sml
|
(Issue #72 is relevant.) |
|
Where are the release notes kept that I would need to update? I'll merge in the latest version of master after #272 is merged, to get a version of this that merges cleanly. |
|
In |
conflict on src/postkernel/Theory.sml, because master started checking whether the name was valid; hopefully resolved correctly
mn200
added a commit
that referenced
this pull request
Aug 5, 2015
Add gen_new_specification to the kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My primary motivation here is to substantiate the claim that the new rule for HOL Constant Definition Done Right has been implemented in HOL4. In reality, there are a few loose ends but I think they can be left for later.
In particular: