Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final ApiDoc created, nplo jsonld & mock_portfolio_generator refactored #24

Merged

Conversation

Purvanshsingh
Copy link
Member

  • I have refactored the nplo jsonld according to our use case
  • Created the final ApiDoc.
  • update hydrus to 0.4.6
  • Vocabparser refactored.
  • conftest & dummy_object_generator updated.
  • mock_portfolio_generator refactored.

The final database schema:

Screenshot from 2021-08-03 20-36-53

All test cases are passing with the final ApiDoc:

Screenshot from 2021-08-03 20-38-35

@open-risk
Copy link
Contributor

The phase 1 classes (borrower, loan, collateral) are no longer relevant (they were generic test classes). Now the role of borrower class is played by private borrower (a special case, eg different from corporate borrower). The role of loan is played by residential mortgage class (which is a type of loan). The role of collateral is played by property collateral class which is the house as collateral for the mortgage loan

The FK structure should be the same as phase 1, but expanded (borrower into portfolio and forbearance etc into borrower). If the ontology has reverse or additional relations they can be ignored (owl is more flexible than sql schema)

@open-risk
Copy link
Contributor

Also counterparty is reduntant. In OWL it plays the role of super class from which various types of borrowers and other entities are derived. This is very non-trivial to implement as API and sql schema so we only implement a 'flat' structure

@Purvanshsingh Purvanshsingh requested review from farazkhanfk7 and open-risk and removed request for open-risk and farazkhanfk7 August 8, 2021 14:08
@Purvanshsingh Purvanshsingh merged commit 75e67a1 into HTTP-APIs:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants