Skip to content

Commit

Permalink
fix empty image formats (#1262)
Browse files Browse the repository at this point in the history
  • Loading branch information
rviscomi authored and sudheendrachari committed Sep 15, 2020
1 parent 54311e0 commit 2e14c93
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sql/util/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This directory contains utilities for managing the Web Almanac dataset on BigQuery.

## [summary_requests.sql](./summary_requests.sql)
## [requests.sql](./requests.sql)

This query generates summary metadata about each request from its JSON-encoded HAR object. For every Web Almanac crawl (eg 2019_07_01 and 2020_08_01) this query should be run once and configured to have its results appended to the `almanac.requests` table. This table is useful for Web Almanac analysis because it combines the metadata of the request with the HAR payload, more easily enabling queries that segment requests by resource type (script, style, image) and base HTML page.

Expand Down
1 change: 1 addition & 0 deletions sql/util/summary_requests.sql → sql/util/requests.sql
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ LANGUAGE js AS """
return 'other';
}
function getFormat(prettyType, mimeType, ext) {
ext = ext.toLowerCase();
if (prettyType == 'image') {
for (type of ['jpg', 'png', 'gif', 'webp', 'svg', 'ico']) {
if (mimeType.includes(type) || ext == type) {
Expand Down

0 comments on commit 2e14c93

Please sign in to comment.