Translation of Resource Hints chapter to Japanese #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tunetheweb Test Website failed. |
|
Looks like another Werkzeug bug. Have pinned it and seems to pass now. Will do a review of this later as heading out now. |
|
Raised this btw: pallets/werkzeug#2481 |
tunetheweb
requested changes
Aug 1, 2022
| image="google-fonts.png", | ||
| alt="Google Fontsのフォントを埋め込むための手順", | ||
| caption='Google Fontsの説明では、fonts.gstatic.comとfonts.googleapis.comへ事前接続するようになっています。（出典: <a hreflang="en" href="https://fonts.google.com/">Google Fonts</a>）', | ||
| description='Code snippet titled "Use on the web" and subtitled with "To embed a font, copy the code into the `<head>` of your html". Code snippet states `<link rel="preconnect" href="https://fonts.googleapis.com"><link rel="preconnect" href="https://fonts.gstatic.com" crossorigin><link href="https://fonts.googleapis.com/css2?family=Roboto&display=swap" rel="stylesheet">`', |
There was a problem hiding this comment.
Should we translate bits of this description?
There was a problem hiding this comment.
Thanks, I translated
tunetheweb
changed the title
tunetheweb
approved these changes
Aug 2, 2022
eeeps
pushed a commit
to eeeps/almanac.httparchive.org
that referenced
this pull request
Aug 11, 2022
* Translation of resource chapter to Japanese * Pin Werkzeug * Better version pin * translate omissions Co-authored-by: Barry Pollard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review for me.
Part of #586