Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 2022 PWA chapter for Simplified Chinese #3192

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

ibelem
Copy link
Member

@ibelem ibelem commented Sep 30, 2022

Part of #1067

@tunetheweb

PTAL.

@rviscomi rviscomi added the translation world wide web label Sep 30, 2022
@rviscomi rviscomi added this to the Backlog milestone Sep 30, 2022
@ibelem
Copy link
Member Author

ibelem commented Oct 3, 2022

@rviscomi Could you please help to enable the CI again then I can check if the linting issues were fixed? Many thanks! 😊

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a note about MDN links.

src/content/zh-CN/2022/pwa.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/pwa.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/pwa.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/pwa.md Outdated Show resolved Hide resolved
@ibelem
Copy link
Member Author

ibelem commented Oct 3, 2022

@tunetheweb Understood, will follow your great suggestions (linting learnings, MDN markdown links etc.,) in translations for other chapters. Many thanks! :)

@tunetheweb tunetheweb merged commit c74338b into HTTPArchive:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants