-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyediting of the HTTP/2 Chapter #334
Conversation
I've made some amends of the copy in this chapter, mainly for readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rachellcostello ! Improved it in many, many places. Do have a few comments though if you don't mind reviewing?
BTW for the internal links I've been using [CDN](./cdn)
rather than the full page, in the chapters I wrote and edited, so they will be language agnostic for when we add other languages so have suggested reverting those back.
I'll give this a review after @bazzadp's feedback is resolved. Don't want to clobber any of his comments. |
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
@rviscomi think you're good to review. Some open comment still above but will leave them for you to give you opinion and can then resolve if you agree with @rachellcostello that I need reigning in - not the first time I've heard this btw... 😊 |
* rick's edits * Update src/content/en/2019/http2.md Co-Authored-By: Barry Pollard <[email protected]> * feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved those other items and added suggestions to add back the missing text.
@rachellcostello you happy with this or feel strongly it shouldn't go back in? Or maybe shouldn't go back in as it currently stands and can be edited more without removing it completely?
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Co-Authored-By: Barry Pollard <[email protected]>
Looks good and happy with any additions you want to make @bazzadp - I love the detail and personal opinions you offer in this chapter! I'd hate to edit it down too far and lose that. |
Thanks so much to both of you! Great job here - especially when having to deal with my ego for a lot of the edits! 😊 As a fellow (wannabe!) editor, I don't think people will appreciate how much work went into the editing. Luckily we're all authors on this too, so will get more than enough credit (hopefully!) for our work there. |
Is this ready to merge? |
Yup think so. |
I've made some amends of the copy in this chapter, mainly for readability.