Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deploy.zip step of deployment #3692

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Remove deploy.zip step of deployment #3692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b7e0f2
Remove deploy.zip
tunetheweb Jun 21, 2024
d77fee8
Remove from ignore files
tunetheweb Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/.gcloudignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,4 @@ static/pdfs/*
**/.DS_Store
Dockerfile
.dockerignore
deployed.zip
.coverage
1 change: 0 additions & 1 deletion src/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@ templates/*/rss.xml
templates/sitemap.xml
static/html/
static/js/web-vitals.js
deployed.zip
.coverage
1 change: 0 additions & 1 deletion src/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ The deploy script will do the following:
- Ask you to complete any local tests and confirm good to deploy
- Ask for a version number (suggesing the last verision tagged and incrementing the patch)
- Tag the release (after asking you for the version number to use)
- Generate a `deploy.zip` file of what has been deployed
- Deploy to GCP
- Push changes to `production` branch on GitHub
- Switch you back to the `main` branch.
Expand Down
10 changes: 0 additions & 10 deletions src/tools/scripts/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,6 @@ LONG_DATE=$(date -u +%Y-%m-%d\ %H:%M:%S)
git tag -a "${TAG_VERSION}" -m "Version ${TAG_VERSION} ${LONG_DATE}"
echo "Tagged ${TAG_VERSION} with message 'Version ${TAG_VERSION} ${LONG_DATE}'"

if [[ -f deployed.zip ]]; then
echo "Removing old deploy.zip"
rm -f deployed.zip
fi

echo "Zipping artifacts into deploy.zip"
# Exclude chapter images as quite large and tracked in git anyway
zip -q -r deployed . --exclude @.gcloudignore static/images/*/*/* static/pdfs/*

echo "Deploying to GCP"
echo "Y" | gcloud app deploy --project webalmanac --stop-previous-version

Expand Down Expand Up @@ -207,7 +198,6 @@ echo -e "${GREEN}Successfully deployed!${RESET_COLOR}"
echo
echo -e "${AMBER}Please update release on GitHub: https://github.com/HTTPArchive/almanac.httparchive.org/releases${RESET_COLOR}"
echo -e "${AMBER}Using tag ${TAG_VERSION}@production${RESET_COLOR}"
echo -e "${AMBER}Please upload deploy.zip as the release artifact${RESET_COLOR}"
echo
echo "Have a good one!"
echo
Expand Down