Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few more edits to the fonts chapter #493

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Conversation

zachleat
Copy link
Member

I think these are important as one of the edits made to the chapter says a thing that I do not necessarily agree with—thanks!

What additional work needs to be done here to get the Unedited flag removed?

@rviscomi rviscomi added the writing Related to wording and content label Nov 15, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Nov 15, 2019
@rviscomi
Copy link
Member

What additional work needs to be done here to get the Unedited flag removed?

The data visualizations also need to be generated, which I hope to get done this weekend.

@tunetheweb
Copy link
Member

I think these are important as one of the edits made to the chapter says a thing that I do not necessarily agree with—thanks!

No problem with these changes, and apologies for putting words in your mouth! I felt the preconnect needed further clarification as per #370 (comment). Did tag you in that but think in the rush to publish we didn't have a huge amount of time to wait to hear back from you on this.

@zachleat
Copy link
Member Author

@bazzadp oh naw it’s okay—I’ve been meaning to circle back to this too—wish I could’ve made it back sooner. Appreciate your help!

@tunetheweb
Copy link
Member

@zachleat could you update this line:

last_updated: 2019-11-11T00:00:00.000Z

to:

last_updated: 2019-11-15T00:00:00.000Z

Just so the sitemap picks it up? Outstanding issue for this (#317) but for now it's manual!

@zachleat
Copy link
Member Author

Done!

@tunetheweb tunetheweb merged commit daaa74a into master Nov 15, 2019
@tunetheweb tunetheweb deleted the fonts-chapter-edits branch November 15, 2019 14:11
@tunetheweb
Copy link
Member

Thanks. Merged. Will let @rviscomi decide whether he wants to publish to prod now, or wait for visualisations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants