Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support translations #684

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Support translations #684

merged 4 commits into from
Mar 17, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Mar 17, 2020

Makes progress on #671

This makes the following changes:

  • If a requested template is a supported language, but the template does not exist it 302 redirects back to English version. This allows partial release of translated templates/chapters.
  • For each template, at rendering time we test each supported language and check if the translated template exists, and only list language if it has been translated. This means the language drop down only shows languages were a translation exists
  • Makes the Language drop down show always - even if only English exists
  • Adds border for Language dropdown always and not just on hover (I found it didn't look like a button without the border)
  • Adds a link to Github to ask for help with Translations
  • Removes top "Start Exploring" link form home page as discussed in Optimize website for wide viewports #574 as doesn't fit when Language Drop down is shown
  • Adds a note to ToC and Prev / Next links to note if chapter has not been translated (see screenshot)
  • Removes Japanese placeholder templates so more obvious these need translated

Screenshots:

Home Page Widget:
image

Home Page Widget with Drop down open:
image

Chapter page drop down with only English:
image

Table of Contents notes which chapters have been translated into that language:

image

Note on French chapter for previous chapter not existing:
image

With this I think we're good to launch the French translations. Will open a separate PR for that.

@tunetheweb tunetheweb merged commit b601ab2 into master Mar 17, 2020
@tunetheweb tunetheweb deleted the enble-translations branch March 17, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants