Show valid date range in initial view #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| ], | ||
| resolve: { | ||
| extensions: ["", ".jsx", ".js"] |
There was a problem hiding this comment.
Not sure what this actually does, but do you need to add "" here? Or does [".jsx", ".js"] work too?
There was a problem hiding this comment.
Adding "" makes it so files required with their extension (e.g. import "./calendar.jsx") can be resolved. It's a default in webpack and I figured it would be good to keep around.
For reference: https://webpack.github.io/docs/configuration.html#resolve-extensions
There was a problem hiding this comment.
Adding @RSO here since he did the initial Karma setup.
|
Apart from that small stylistic suggestion this looks good to me! |
martijnrusschen
added a commit
that referenced
this pull request
Dec 14, 2015
Show valid date range in initial view
|
Thanks! |
|
Awesome, thanks for the CR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209
If minDate is after the current date, the focus is set to minDate, and if maxDate is before the current date, the focus is set to maxDate.