Fix #4644: Handle the visibility of the previous and the next year navigation when showQuarterYearPicker is enabled #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@balajis-qb you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4652 +/- ##
==========================================
+ Coverage 96.97% 96.99% +0.02%
==========================================
Files 28 28
Lines 2608 2632 +24
Branches 1102 1114 +12
==========================================
+ Hits 2529 2553 +24
Misses 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Code & tests look good. Just one variable name confused me for a second. Not a big deal though.
Reviewed with ❤️ by PullRequest
src/date_utils.js
Outdated
| @@ -654,6 +655,36 @@ | |||
| ); | |||
| } | |||
|
|
|||
| export function quarterDisabledBefore(day, { minDate, includeDates } = {}) { | |||
balajis-qb
pushed a commit
to qburst/react-datepicker-3
that referenced
this pull request
Apr 1, 2024
added 2 commits
April 1, 2024 15:14
…button for the showQuarterYearPicker flag Closes Hacker0x01#4644
balajis-qb
force-pushed
the
issue-4644/fix/showQuarterYearPicker-navigation-button-visibility
branch
from
8ac9e76
to
0407962
Compare
|
Looking good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #4644
Problem
As mentioned in the linked issue, the QuarterYearPicker has some issue with the visibility of the next and the previous arrow buttons based on the minDate and the maxDate. That's because we are not handling the Quarter year picker separately, but handling it with the month picker logic
Changes
date_utils.jsto achieve the resultContribution checklist