-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4644: Handle the visibility of the previous and the next year navigation when showQuarterYearPicker is enabled #4652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@balajis-qb you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 114
- 1
63% JavaScript (tests)
37% JavaScript
Type of change
Fix - These changes are likely to be fixing a bug or issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4652 +/- ##
==========================================
+ Coverage 96.97% 96.99% +0.02%
==========================================
Files 28 28
Lines 2608 2632 +24
Branches 1102 1114 +12
==========================================
+ Hits 2529 2553 +24
Misses 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code & tests look good. Just one variable name confused me for a second. Not a big deal though.
Reviewed with ❤️ by PullRequest
src/date_utils.js
Outdated
@@ -654,6 +655,36 @@ | |||
); | |||
} | |||
|
|||
export function quarterDisabledBefore(day, { minDate, includeDates } = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 👍
…button for the showQuarterYearPicker flag Closes Hacker0x01#4644
8ac9e76
to
0407962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you! |
Description
Linked issue: #4644
Problem
As mentioned in the linked issue, the QuarterYearPicker has some issue with the visibility of the next and the previous arrow buttons based on the minDate and the maxDate. That's because we are not handling the Quarter year picker separately, but handling it with the month picker logic
Changes
date_utils.js
to achieve the resultContribution checklist