Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export CalendarContainerProps interface #4914

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

plahteenlahti
Copy link
Contributor

The CalendarContainerProps interface is now exported, allowing other modules to import and use it.

Problem
CalendarContainerProps wasn't exported

Changes
Export the interface

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

The `CalendarContainerProps` interface is now exported, allowing other modules to import and use it.
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@plahteenlahti you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 1
- 1

100% TSX

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (0c27496) to head (f2aa65a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4914   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          28       28           
  Lines        3264     3264           
  Branches     1359     1355    -4     
=======================================
  Hits         3155     3155           
  Misses        105      105           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds one export to an interface. Looks good to me.

Image of Simon Simon


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a trivial change; I have no concerns.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants