try fixing JS error on website #5120
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
Check the status or cancel PullRequest code review here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5120 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 29 29
Lines 3350 3350
Branches 1405 1409 +4
=======================================
Hits 3246 3246
+ Misses 104 102 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
|
This change is hard to test, since I'm not seeing the error locally. |
There was a problem hiding this comment.
It's difficult to tell from the context alone whether it'll solve the issue, but it's not a bad idea to have this check in any situation.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
I believe I am seeing the issue locally, and this fix potentially did not resolve the issue.
Reviewed with ❤️ by PullRequest
|
Oh interesting, and yes you're right this didn't fix the issue. |
|
Ryan, Are you able to share more detail on what you're seeing locally? |
Our main website is getting an error: https://reactdatepicker.com/
TypeError: k.format is not a functionPossible fix for #5108