Improve language for email overlap error #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
force-pushed
the
MattIPv4/improve-overlap-error
branch
from
1974c6a
to
6789b89
Compare
davidcarlsonberg
approved these changes
Oct 9, 2024
erhilse
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What should this PR do?
Updates the wording show in the error message when an overlapping email address is encountered, to account for both the wrong account being used but also when people might be attempting to link GitHub + GitLab (incorrectly).
What issue does this relate to?
N/A
What are the acceptance criteria?
Updated language reads correctly and accounts for both edge-cases that are likely to trigger this error.
Can be seen at
/auth/?error_code=InvalidCredentials&error_message=Account already exists with matching email address.