This repository has been archived by the owner on May 22, 2020. It is now read-only.
RVM-906: Rvm Core Analytics Pipeline #925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun2k15
requested review from
rdepena,
datamadic,
StevenEBarbaro and
omerli
openfin-github-bot
bot
added
the
auto testing started
Test Results for 588fef5
|
openfin-github-bot
bot
added
auto testing done
rdepena
reviewed
Sep 17, 2019
src/browser/rvm/rvm_message_bus.ts
Outdated
| const rvmMsg: CoreAnalytics = { | ||
| topic: 'system', | ||
| action: 'send-core-analytics-event', | ||
| sourceUrl: '', |
There was a problem hiding this comment.
I could see a world where we would want to tie analytics to a specific application, how would you recommend we handle that?
There was a problem hiding this comment.
Not sure the best solution, but I think we could pass an optional Identity param.
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
datamadic
suggested changes
Sep 25, 2019
| @@ -173,13 +174,27 @@ export interface Cleanup extends RvmMsgBase { | |||
| // topic: system ----- | |||
| type systemTopic = 'system'; | |||
| type getRvmInfoAction = 'get-rvm-info'; | |||
| type sendCoreAnalyticsEvent = 'send-core-analytics-event'; | |||
There was a problem hiding this comment.
This is the same name as the function, not sure if that was intentional
| @@ -415,6 +430,35 @@ export class RVMMessageBus extends EventEmitter { | |||
| }; | |||
| this.publish(rvmPayload, callback); | |||
| } | |||
|
|
|||
| public sendCoreAnalyticsEvent(event: string, payload: any, identity?: Identity): Promise<boolean> { | |||
There was a problem hiding this comment.
We don't actually use this yet, are there plans to use it soon?
datamadic
approved these changes
Oct 3, 2019
|
I'm OK with this for now, lets perhaps revisit when you guys flesh out the usage |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added a member function to the rvmBus that communicates with the RVM analytics pipeline. Not being used for anything at the moment, but able to be leveraged.
Checklist
npm testpassesRelease Notes
Notes: