feat: layer diffuse #272
Merged
feat: layer diffuse #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tazlin
requested changes
Jun 22, 2024
There was a problem hiding this comment.
As mentioned in discord, there needs to be handling to account for the model download and use supporting AIWORKER_CACHE_HOME.
Further, I think that introducing 3gb+ of VRAM overhead with this feature presents potential problems, especially with making sure the new model introduced with this feature is getting unloaded at the correct times. I am only raising my concerns and am not vetoing the feature as a whole. I do think it is useful feature in theory but has the potential to introduce memory-related stability problems without further testing.
tazlin
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Layer Diffuse via https://github.com/huchenlei/ComfyUI-layerdiffuse
Also pin numpy as v2 breaks us