Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use comfyui 7df42b9a #309

Merged
merged 3 commits into from
Aug 23, 2024
Merged

feat: use comfyui 7df42b9a #309

merged 3 commits into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. feat: use comfyui 7df42b9a

    @tazlin
    tazlin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    be8107c View commit details
    Browse the repository at this point in the history

  2. fix: support changes to 'prompt' caching mechanism 

    In comfyui internals, 'prompt` actually refers to an entire set of nodes and settings. Previously, we were hijacking the `recursive_output_delete_if_changed` call, but a recent change in comfyui has switched this behavior to the class `IsChangedCache`. The hook in place before had more to do with detecting bugs to do with caching than anything else, so I've implemented a similar sort of hijack for `IsChangedCache`.
    @tazlin
    tazlin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    13c8617 View commit details
    Browse the repository at this point in the history

  3. fix: use better assumptions for images_received 

    The presence of the key `output` in `data` during `send_sync` calls was enough to assert `data["output"]["images"]` was present and populated (i.e., we are post-inference and receiving the final images from comfyui). However, comfyui internals have changed so that `data["output"]["images"]` can be equal to `None` in ordinary circumstances during other stages of generation. As such, I have changed the logic to check for the key and for non-`None` values.
    @tazlin
    tazlin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    55139fc View commit details
    Browse the repository at this point in the history