fix: unload from RAM as intended; force empty cache #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the following erroneous behavior was in play: - `unload_all_models_vram()` did not effectively remove all models from VRAM - `unload_all_models_ram()` did not remove any models from RAM - With AMD specifically, though its possible more generally as well, the torch cache was not cleared as this required an argument (`True`) sent to `_comfy_soft_empty_cache(...)` I have also added some additional logging to help further identify what is and is not helpful.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the following erroneous behavior was in play:
unload_all_models_vram()did not effectively remove all models from VRAMunload_all_models_ram()did not remove any models from RAMTrue) sent to_comfy_soft_empty_cache(...)I have also added some additional logging to help further identify what is and is not helpful.