Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject negative embeddings correctly #70

Merged
merged 5 commits into from
Sep 6, 2023
Merged

fix: inject negative embeddings correctly #70

merged 5 commits into from
Sep 6, 2023

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Sep 6, 2023

See #69

also reworks test to confirm this behavior.

also reworks test to confirm this behavior
@db0
Copy link
Member

db0 commented Sep 6, 2023

All the expected images are the same which is not right.

@tazlin
Copy link
Member Author

tazlin commented Sep 6, 2023

I have changed the tests to expect the same image on output. The purpose of this is to make sure the inject behavior is working in a predictable way.

@db0
Copy link
Member

db0 commented Sep 6, 2023

Ah I see. If you think it helps with noticing issues, sure, but normally the comparison of the images would be automated. The pedant in me wants to mention that you could avoid uploading 3 references by pointing them all the same image :D

@tazlin
Copy link
Member Author

tazlin commented Sep 6, 2023

I can just as soon do that. All I really want separate are the test output images anyway.

Although, I do think it would highlight the fact to a manual review that they are expected to be the same with the duplicate images (as in, on a test failure).

@tazlin tazlin merged commit 87e7c57 into main Sep 6, 2023
1 check passed
@tazlin tazlin deleted the ti-fix branch September 6, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants