Simplify sorting of individuals in mu_plus_lambda
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschmidt87
requested changes
Jul 2, 2020
jakobj
force-pushed
the
maint/refactor-mu-plus-lambda-sort
branch
from
291d89b
to
2042586
Compare
jakobj
force-pushed
the
maint/refactor-mu-plus-lambda-sort
branch
from
2042586
to
9a13d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My brain was getting too hot whenever i looked at this function. Isn't this implementation much easier? It seems that we can handle the replacement
nan->-np.infon the fly in the function used forkey, no need for creating a copy of the population which we modify and then argsort.