Allow multiple parameters for nodes and add example with parametrized additive node #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
changed the title
mschmidt87
requested changes
Jul 20, 2020
jakobj
force-pushed
the
enh/mul-add-parameters-3.0
branch
from
5b91967
to
a36e441
Compare
|
good point! i've adapted the example to include proper documentation that can be properly rendered. please have another look. |
mschmidt87
requested changes
Jul 27, 2020
|
thanks for your input @mschmidt87! i've included your suggestions, please have another look |
mschmidt87
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Very nice, looks good to me.
One small thing: Can you add this example to the travis file. After merging #205 , this won't be necessary but at the moment, it's not clear which one we merge first.
jakobj
force-pushed
the
enh/mul-add-parameters-3.0
branch
from
b821a37
to
9cee41f
Compare
|
thanks! added the example to travis, sqashed, now waiting for green light from travis before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #178 this is now incredibly easy: one can just define new custom nodes that implement certain operations and may contain parameters that can be adapted via local search. This PR includes a fix for nodes that use more than one parameter and example for how to make use of the new power of #178 ;)
Should we include this parametrized add as a new default node? Or is is so simple now to define nodes that we don't need it?
closes #98