-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing n_columns=0
#299
Testing n_columns=0
#299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks for working on this! 🚀
i've added a few inline comments that should be addressed.
regarding your question: the low-level error was generated because the genome was not initialized. in also, i think we should not explicitly forbid n_columns=0
if our library does the right thing, why not?
Ok, i am a bit lost. Somehow the test doesn't pass on the python 3.7 testsuite, however I can't reproduce the error locally. Any ideas why? |
I also tried to reproduce the error locally without success. I also tried to google the error and found this link which might (or might not) be helpful: https://stackoverflow.com/questions/66640404/basic-loop-with-sympy-gives-me-this-error-message-symbol-object-is-not-subsc
|
have you tried rebasing on the most recent master? one of the recent PRs has removed the necessity to do |
1ea4e7b
to
bc3cb25
Compare
bc3cb25
to
2fe4d0f
Compare
ah yes, that was it! my bad, thanks for suggesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! 👍
and merging
So, weirdly
n_columns = 0
works in the minimal example and in a small test in population it gives the expected sympy expression. However a lower level test fails when calling directlyCartesianGraph(genome).to_sympy()
. Any ideas why?Also imo we should rather deprecate the
n_columns=0
orn_rows=0
functionality, since they don't make much sense anyway.Closes #283