Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine github workflow and freeze some packages #368

Merged

Conversation

jakobj
Copy link
Member

@jakobj jakobj commented Jun 22, 2022

As the title suggests.

closes #363

@jakobj jakobj added this to the 0.4.0 milestone Jun 22, 2022
- `click` for compatibility with `black`
- `jinja2` for compatibility with `sphinx`
- `gym` for compatibility with mountain car example
@jakobj jakobj changed the title Separate github workflow steps to make errors more easibly traceable Refine github workflow and freeze some packages Jun 22, 2022
Copy link
Member

@mschmidt87 mschmidt87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason to freeze those packages? Or just a general policy that it's better to freeze instead of being surprise by new releases?

.github/workflows/tests.yaml Show resolved Hide resolved
@jakobj
Copy link
Member Author

jakobj commented Oct 24, 2022

Is there a particular reason to freeze those packages? Or just a general policy that it's better to freeze instead of being surprise by new releases?

yep, it's necessary to make everything play well together. it's a consequence of having chosen to freeze some packages :( but see #369 for the future of this!

@jakobj jakobj merged commit 35ce5ae into Happy-Algorithms-League:master Oct 24, 2022
@jakobj jakobj deleted the maint/separate-ci-checks branch October 24, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run code checks in workflow separately
2 participants