-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCR doesn't record when keys and mouse used simultaneously #1739
Comments
IBwWG
referenced
this issue
Feb 23, 2016
IBwWG
pushed a commit
to codingthat/flixel
that referenced
this issue
Feb 23, 2016
IBwWG
pushed a commit
to codingthat/flixel
that referenced
this issue
Feb 23, 2016
The PR should be good to go, now, unless I missed anything else. |
IBwWG
added a commit
to codingthat/flixel
that referenced
this issue
Apr 22, 2016
IBwWG
added a commit
to codingthat/flixel
that referenced
this issue
Apr 22, 2016
Fix VCR to record simultaneous keys+mouse, closes HaxeFlixel#1739 (HaxeFlixel#1825)
Aurel300
pushed a commit
to larsiusprime/haxeflixel
that referenced
this issue
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code snippet reproducing the issue:
(any working VCR. try a "shift-click" for example, then try to find it in the .fgr output)
Observed behavior: No shift-click recorded, only surrounding shifts.
Expected behavior: Record the shift-click.
Cause: This behaviour seems oddly intentional, but maybe there was a different intention behind the following code, originally:
See, if either keys or mouse are null this frame, then we hit
continueFrame = false
and the frame gets recorded. But if neither are null, it defaults to true, and the frame is incremented and the function returns without recording.My best guess is the intention was to skip frames that didn't have keyboard or mouse input (I took care of this in my PR) but that the logic got implemented backwards--it probably should've been that continueFrame is false by default, and only made true if either keys or mouse are not null, i.e. only record when there's something to record.
The text was updated successfully, but these errors were encountered: