Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxTilemap buffers are not updated on camera resize or replacement #1801

Closed
Gama11 opened this issue Apr 2, 2016 · 3 comments
Closed

FlxTilemap buffers are not updated on camera resize or replacement #1801

Gama11 opened this issue Apr 2, 2016 · 3 comments
Assignees
Milestone

Comments

@Gama11
Copy link
Member

Gama11 commented Apr 2, 2016

Nicely demonstrated by a sample project from @jscott1989: https://github.com/jscott1989/camera-test

@Gama11 Gama11 self-assigned this Apr 2, 2016
@buckle2000
Copy link
Contributor

I think there is not a easy solution but call tilemap.updateBuffers() manually on changing cameras.

Because FlxBasic is not notified when its main camera changed:

private function get_camera():FlxCamera
    {
        return (_cameras == null || _cameras.length == 0) ? FlxCamera.defaultCameras[0] : _cameras[0];
    }

@Gama11
Copy link
Member Author

Gama11 commented Apr 10, 2016

I mostly solved this locally, it involves adding a few new FlxSignals for certain "camera events". I struggled with adding proper unit tests for this though..

@Gama11 Gama11 added this to the 4.1.0 milestone Apr 26, 2016
Beeblerox added a commit that referenced this issue May 1, 2016
@Gama11 Gama11 modified the milestones: 4.1.0, 4.2.0 Jul 10, 2016
@Gama11 Gama11 closed this as completed in edf93b5 Aug 21, 2016
@Gama11
Copy link
Member Author

Gama11 commented Aug 21, 2016

Eh, I didn't mean to close this just yet.

@Gama11 Gama11 reopened this Aug 21, 2016
@Gama11 Gama11 closed this as completed in e5e0c9d Aug 21, 2016
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this issue Apr 18, 2018
Necessary to fix HaxeFlixel#1801, and probably otherwise useful as well.
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this issue Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants