-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlxGame#new()'s confusing zoom parameter #1977
Comments
Looks like there's actually not a single demo that has |
Does the fix in 96dccf0 look sensible? |
Yeah, that looks correct. :) |
I changed |
Same here, the Zoom parameter in FlxGame's constructor doesn't seem to have any effect. |
Clearing out 5.0.0 tasks, was this completed? |
I tried various demos with a zoom other than 1 and it didn't seem to have any effect on the "pixel size" like the documentation claims. I say we remove this property, and better teach scalemodes |
Following my change in #1889 to make scrollbounds account for zoom, a couple of people have had issues due to the zoom parameter of FlxGame#new() not being set to 1 (#1976).
It seems that in both cases there was confusion about the meaning of said parameter, where it was interpreted to have an actual impact on the scale of the game, whereas it's actual meaning now seems to be "what value of zoom should count as not zoomed". My change did not take this into account and so does not work for other values in here. I believe it could be fixed simply by dividing the value of zoom that is used in updateScrollBounds by the game's defaultZoom, although this wouldn't help with the continued misinterpreting of the scroll parameter, which seems to have lost it's utility since the introduction of scale modes.
In the coming weeks when I have time I'll modify updateScrollBounds to account for other FlxGame zoom values. Is there any reason for this parameter to be kept long term, or should it ultimately be removed with the next batch of breaking changes?
The text was updated successfully, but these errors were encountered: