Safe alloc optimizations + usage of flixel math objects in PixelPerfectCollision function #1760
Conversation
…ctCollision function.
| @@ -15,6 +15,7 @@ class FlxPointer | |||
|
|
|||
| private var _globalScreenX:Int = 0; | |||
| private var _globalScreenY:Int = 0; | |||
| private static var _cachedPoint:FlxPoint = new FlxPoint(); | |||
There was a problem hiding this comment.
Should maybe just be _point? That's how it's called in most other classes.
There was a problem hiding this comment.
I'm trying to make it obvious that these are static cached values (to prevent confusion or accidental deletion), but I am open to changing this (or other classes) to better fit existing conventions.
It does introduce an issue with variables named dx, or _cachedFloat, where _cached clearly prefix helps with readability.
There was a problem hiding this comment.
I was specifically talking about this FlxPoint var here. I agree that the floats would be quite even more confusing without the prefix.
There was a problem hiding this comment.
I would prefer to stick with the _cached convention, if there are _point variables that are static for caching purposes, we should rename it to _cachedPoint.
…occurs if there are records to be processed.
|
I partially merged this (mostly the parts that didn't have merge conflicts: |
No description provided.