HTML5FrontEnd: Add platform and mobile detection #1897
Conversation
| @@ -59,6 +61,49 @@ class HTML5FrontEnd | |||
| { | |||
| return Browser.window.innerHeight; | |||
| } | |||
|
|
|||
| private inline function get_platform():FlxPlatform | |||
There was a problem hiding this comment.
This function is way to long to be a good candidate for inline.
There was a problem hiding this comment.
We could probably just run this entire thing once in new() and cache the result? It's not like it's gonna change at runtime, right? :)
| private function new() | ||
| { | ||
| browser = getBrowser(); | ||
| browserWidth = getBrowserWidth(); |
There was a problem hiding this comment.
Browser width and height could change at runtime, so I don't think caching those is a good idea.
| WINDOWS; | ||
| LINUX; | ||
| UNIX; | ||
| MAC; |
|
I think we really need more people to test this |
|
Sorry for my ignorance. Here's my reference. So you're saying it should be removed? |
|
I'm not sure, I was mostly asking out of ignorance as well. ;) |
|
Maybe it's for some kind of Unix-based OS which is probably rarely used by our users. So I guess it should be removed anyway. |
Replace iOS with iPhone/Pad/Pod Add missing Mac (oops) Remove Unix
|
It feels a bit strange to have IPOD / IPAD / IPHONE in the enum directly, since everything else in there is an OS... It might make sense to continue having |
|
Thanks! :) |
I added
platformandisMobilevariables toFlxG.html5.Tested on Windows and Android. Not sure about the others. Here's a test (https://github.com/DleanJeans/flixel-html5-platform-test).