FlxRandom: add shuffle(), deprecate shuffleArray()

[ttencate]

Deprecate FlxRandom#shuffleArray() in favour of this.

Fixes #1914.

Unlike shuffleArray(), I decided not to return the shuffled array, to make it crystal clear from the API that the array is modified in place rather than cloned.

[Gama11]

Wow, you even added unit tests. 👍

[ttencate]

Leaving the * import from Hamcrest in place. That's the way Hamcrest was meant to be used; things get super verbose otherwise.

[Gama11]

It seems that leads to another deprecation warning though?

/home/travis/haxe/lib/hamcrest/2,0,1/org/hamcrest/collection/IsHashContaining.hx:36: characters 26-34 : Warning : Usage of this typedef is deprecated

https://travis-ci.org/HaxeFlixel/flixel/jobs/159246970#L378

[ttencate]

That's in Hamcrest, here. It references the deprecated standard typedef IMap. I filed an issue against hamcrest.

[Gama11]

I see... thanks.

I added an exclude to the checkstyle config, but CodeClimate doesn't seem to care much, not sure why...

The custom @:deprecated message doesn't allow concatenation it seems. Without that, it actually shows up.

[ttencate]

Sorry, first contribution 😊 Thanks for cleaning up!

[Gama11]

To be fair, that @:deprecated behavior is a bit unexpected. :)