Add tooltips to FlxG.debugger #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beeblerox
reviewed
Dec 1, 2016
| */ | ||
| public function destroy():Void | ||
| { | ||
| if (_shadow != null) |
There was a problem hiding this comment.
you could use _shadow = FlxDestroyUtil.removeChild(this, _shadow);
and for _background and _text also
There was a problem hiding this comment.
Thanks for the tip! It looks like @Gama11 was faster than me to fix it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the use of tooltips in the debugger. Any
Spriteelement child ofFlxG.debuggercan receive a tooltip using the callTooltip.add(element, text). I decided for a static method in theTooltipclass instead of something likeFlxG.debugger.tooltip.add()to keep the API internal and hidden from HaxeFlixel users.I also added tooltips to the tools in
FlxG.debugger.interaction.