Keyboard gamepad fixes #2253
Merged
Keyboard gamepad fixes #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gama11
reviewed
Apr 14, 2020
| @@ -135,25 +141,37 @@ class FlxKeyManager<Key:Int, KeyList:FlxBaseKeyList> implements IFlxInputManager | |||
| * @param Status The key state to check for. | |||
| * @return Whether the provided key has the specified status. | |||
| */ | |||
| public function checkStatus(KeyCode:Key, Status:FlxInputState):Bool | |||
| public inline function checkStatus(KeyCode:Key, Status:FlxInputState):Bool | |||
There was a problem hiding this comment.
This function is too complex to be inline.
There was a problem hiding this comment.
I mostly did this to match FlxGamepad.checkStatus but it should work because checkStatus should always be called with a literal key value through inlined getters like FlxG.keys.pressed.A which is inlined and assumedly optimized all the way down the call stack to become:
var key = getKey(KeyCode);
var tmp:Bool
if (key == null)
tmp = false;
else
tmp = key.hasState(Status);
otherwise only checkKeyArrayState should get the full inline. of course, people can call this method, as it's public and that can cause problems. I thought about making it private and adding @:allow(flixel.input.FlxBaseKeyList) to it. but that might screw up someone's project.
|
Thanks, these changes all make sense to me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was made to close #2249 but it unveiled some other, related inconsistencies. I can split this up into multiple PRs if needed.
FlxG.keys.anyPressed([ANY])return true if any key is pressed, previously it would always return false.myGamePad.pressed.Atrue when A is eitherPRESSEDorJUST_PRESSED. Previously, it would be false if just pressed.FlxKey.NONEto FlxKeyList, since game pads have this feature.FlxG.keys.releasedsince game pads had that too.