Add ability to change FlxText leading

[DigiEggz]

No description provided.

[Gama11]

I'm not sure if it's usfeul enough to warrant a new top-level field, evidently there hasn't been much of a demand for it thus far. It's a bit more verbose, but I think you should already be able to set the leading via text.addFormat().

[DigiEggz]

I'm not sure if it's usfeul enough to warrant a new top-level field, evidently there hasn't been much of a demand for it thus far. It's a bit more verbose, but I think you should already be able to set the leading via text.addFormat().

addFormat() takes in FlxTextFormat, but unfortunately it doesn't accept leading as a parameter. Would it be better to expand what FlxTextFormat accepts?

[Gama11]

I don't think it needs to, this should work?

var format = new FlxTextFormat();
format.format.leading = something;

[DigiEggz]

I don't think it needs to, this should work?

var format = new FlxTextFormat();
format.format.leading = something;

format is local, so it cannot be accessed from a FlxTextFormat variable. If the variable was set to public and then added via addFormat(), I am still unsure of the correct way to call updateDefaultFormat to redraw the sprite.

[Gama11]

Oh right, it's private. I guess it could simply be added as a constructor parameter of FlxTextFormat.

I am still unsure of the correct way to call updateDefaultFormat to redraw the sprite.

I don't think that's necessary, addFormat() sets _regen, which leads to a redraw.

[DigiEggz]

Oh right, it's private. I guess it could simply be added as a constructor parameter of FlxTextFormat.

I am still unsure of the correct way to call updateDefaultFormat to redraw the sprite.

I don't think that's necessary, addFormat() sets _regen, which leads to a redraw.

I tried adding a parameter for leading when creating a new FlxTextFormat, but using addFormat() does not reflect the changes. Things such as the text color are updated for the sprite, but the leading property isn't visually updated.

FlxBitmapText has lineSpacing, which lets you adjust the distance between lines. Would naming it something like this make it more obvious / useful? As it stands, I can't find a way to adjust it on FlxText.

[Gama11]

I guess copyTextFormat() also needs to be updated?

Thinking on it again, a public leading property on FlxTextFormat is probably better than a new constructor parameter. Otherwise we'll end up with too many parameters if we want to expose more TextFormat properties in the future.

[DigiEggz]

I guess copyTextFormat() also needs to be updated?

Thinking on it again, a public leading property on FlxTextFormat is probably better than a new constructor parameter. Otherwise we'll end up with too many parameters if we want to expose more TextFormat properties in the future.

Thanks for copyTextFormat() clue!

I've changed it so that it adds a public field to change the leading property on TextFormat.

Edit: In the steep part of my GitHub learning curve. Accidentally reverted the update. Not sure how to go back to the correct changes, which are in dd72a4a