better warnings for invalid width/height args #2762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
animation.add
with frame indices higher than the sprite's total number of frames, it won't add those frames and it wont log a warning.animation.add
with no valid frame indices, it won't create the animation, and it won't log a warning.No animation called "$name"
This caused issued where people with incorrect width/height args would get warnings when trying to play anims, and they have no idea why.
Now
Example: