Fix for FlxStrip when drawDebug is true #2904

[UncertainProd]

Fixes #2904, I tested it on html5 and windows

[Geokureli]

Sweet! I'll try this out later today

[Geokureli]

Thanks! this probably saves me days of debugging

[Geokureli]

@UncertainProd do you know what this line actually does? commenting it out seems to change nothing, and I still get bad performance when drawDebug is enabled and FlxStrips are displayed, even in ignoreDrawDebug is enabled for them

regardless, things are better with your fix, but I'm left with many more questions

[UncertainProd]

Honestly, even I'm not too sure. It looks like it's meant to draw some extra stuff when drawDebug is enabled but I don't see anything different being drawn either way

[UncertainProd]

Update: I found that if you add the following 2 lines in the update() method of PlayState in the FlxClothSprite demo, then it shows you the vertices used in the cloth sprite (which also uses drawTriangles)
Code to add:

if (FlxG.keys.justPressed.SPACE)
{
    FlxG.debugger.drawDebug = !FlxG.debugger.drawDebug;
}

This results in:

Turns out FlxClothSprite overrides it's drawDebugOnCamera method to achieve this. Maybe something like this was the intended effect in FlxStrip but drawTriangles doesn't seem to work with lineStyles like the other openfl drawing commands.

[Geokureli]

I may have discovered the source of my performance issues, I talk about it here

Turns out FlxClothSprite overrides it's drawDebugOnCamera method to achieve this. Maybe something like this was the intended effect in FlxStrip but drawTriangles doesn't seem to work with lineStyles like the other openfl drawing commands

yeah maybe they wanted this kind of wireframe drawing on all triangles, rather than having each FlxStrip implementing their own version, but the one in FlxDrawTrianglesItem broke, or only worked in flash and no one noticed. Then, when FlxClothSprite was introduced they unknowingly reinvented the broken wheel?

[UncertainProd]

Yeah, I think so

[Geokureli]

Update: I found that if you add the following 2 lines in the update() method of PlayState in the FlxClothSprite demo, then it shows you the vertices used in the cloth sprite (which also uses drawTriangles):

does this wireframe show up even if you comment out these lines: https://github.com/UncertainProd/flixel/blob/dev/flixel/graphics/tile/FlxDrawTrianglesItem.hx#L91-L98

If so, I think we should just remove them or maybe put #if !flash

[UncertainProd]

does this wireframe show up even if you comment out these lines: https://github.com/UncertainProd/flixel/blob/dev/flixel/graphics/tile/FlxDrawTrianglesItem.hx#L91-L98

Yeah the wireframe shows up even after commenting it out

[UncertainProd]

Also, when I replace those lines with the following in FlxDrawTrianglesItem, it does outline the triangles being drawn:

if (FlxG.debugger.drawDebug)
{
			var gfx:Graphics = camera.debugLayer.graphics;
			gfx.lineStyle(1, FlxColor.BLUE, 0.5);
                        // draw a triangle path for each triangle in the drawitem
			var i = 0;
			while (i < indices.length)
			{
				var indexToPoint = (idx:Int) ->
				{
					return [vertices[idx * 2], vertices[idx * 2 + 1]];
				};
				var pt1 = indexToPoint(indices[i]);
				var pt2 = indexToPoint(indices[i + 1]);
				var pt3 = indexToPoint(indices[i + 2]);
				gfx.drawPath(Vector.ofArray([MOVE_TO, LINE_TO, LINE_TO, LINE_TO]), Vector.ofArray([
					pt1[0], pt1[1],
					pt2[0], pt2[1],
					pt3[0], pt3[1],
					pt1[0], pt1[1],
				]));
				i += 3;
			}
}

[Geokureli]

Also, when I replace those lines with the following in FlxDrawTrianglesItem, it does outline the triangles being drawn:

Nice! I didn't know global vertex drawing was that easy, however I feel like this feature should be tied to some flag on the FlxStrip, something like strip.debugDrawWireFrame and/or ignoreDrawDebug rather than relying solely on FlxG.drawDebug

[UncertainProd]

I didn't know global vertex drawing was that easy

Yeah although it did take me a bit of searching to understand how that (and drawTriangles in general) worked 😅

I feel like this feature should be tied to some flag on the FlxStrip, something like strip.debugDrawWireFrame and/or ignoreDrawDebug rather than relying solely on FlxG.drawDebug

True

[Geokureli]

... it did take me a bit of searching to understand how that (and drawTriangles in general) worked 😅

I'm in the same boat, thanks for all you've done!

[UncertainProd]

No problem!