Remove unused stuffs #3228
Remove unused stuffs #3228
Conversation
flixel/FlxCamera.hx
Outdated
| static var renderPoint:FlxPoint = FlxPoint.get(); | ||
| static var renderPoint:FlxPoint = new FlxPoint(); | ||
|
|
||
| static var renderRect:FlxRect = FlxRect.get(); | ||
| static var renderRect:FlxRect = new FlxRect(); |
There was a problem hiding this comment.
Its incorrect usage, since its a static it is only ever gotten once. And never .put(). And if someone were to use .put on it it would break
There was a problem hiding this comment.
I disagree that it's "incorrect", it makes absolutely no difference
flixel/flixel/math/FlxPoint.hx
Lines 300 to 303 in 94dbde5
plus, using get isn't an indication that it's okay to call put
There was a problem hiding this comment.
Oh i didnt know it was changed. It used to make a difference before the reworked in commit e721fca. Should i revert the commit?
There was a problem hiding this comment.
What difference did it make? I don't understand what you're referring to, or why we would revert anything
There was a problem hiding this comment.
Eh just forget it. Do i need to do anything?
NeeEoo
force-pushed
the
remove-unused-stuffs
branch
from
e7d9c00
to
959267b
Compare
|
I'm not interested in these changes at the moment, at some point I'd like to assess whether we can add blendmode support back in, until then I'd leave it as is |
This was used when FLX_DRAW_TILES still existed. And quads still uses blend modes with overrideBlendMode() in flxdrawquaditem |
|
I'm aware, as I said, I think before we gut it we should see if it can be reimplemented |
This removes some old stuff which was no longer used.