Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semaphores and condition variables. #495

Conversation

Apprentice-Alchemist
Copy link
Contributor

@ncannasse
Copy link
Member

Hello. As it's not part of the Haxe standard library, please create your own hdll for additional primitives.

@ncannasse ncannasse closed this Nov 25, 2021
@Aurel300
Copy link
Member

@ncannasse The PR linked in the description (HaxeFoundation/haxe#10503) is adding semaphores to the stdlib and implementing it for all sys targets.

@ncannasse ncannasse reopened this Nov 26, 2021
@ncannasse
Copy link
Member

Ok. But first please make when you submit a PR not to change the formatting of existing files :)

@RealyUniqueName
Copy link
Member

@ncannasse The PR in Haxe repo is ready. Could you please review this one?

@ncannasse
Copy link
Member

Seems good, however should use tabs instead of spaces as other parts of the HL code ;)

@Apprentice-Alchemist
Copy link
Contributor Author

Apprentice-Alchemist commented Dec 1, 2021

Spaces have been replaced with tabs.
(I think you should consider adding a .clang-format file with the style you want.)

@ncannasse ncannasse merged commit ef50a45 into HaxeFoundation:master Dec 5, 2021
@ncannasse
Copy link
Member

Thanks!

@Simn Simn mentioned this pull request Dec 14, 2021
crazyjul pushed a commit to playdigious/hashlink that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants