Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Standardise install tree for windows build #709

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Sep 6, 2024

As discussed in #705 (comment), this changes the install tree for windows builds in cmake to match the vs2019 generated packages, rather than in separate bin and lib directories.

This way a cmake install of hashlink will work with the visual studio hlc templates.

I've also changed the default install location on windows to be C:\HaxeToolkit\hashlink.

For cmake builds using MSVC, it now installs in with the same install
tree as the package from the visual studio sln build.

This means that the visual studio hlc templates can now also support
cmake installs of hashlink.
@yuxiaomao
Copy link
Collaborator

Thank you! Before merge, I'd like to know, (as your PR only affect Windows build,) if it's better to also change the path for Linux/OSX build - or not?

@tobil4sk
Copy link
Member Author

tobil4sk commented Sep 9, 2024

Thank you! Before merge, I'd like to know, (as your PR only affect Windows build,) if it's better to also change the path for Linux/OSX build - or not?

On Mac and Linux it's not possible to stop installing to bin and lib, this is required for the binaries to run and load correctly.
It would be possible to override this just for packaging (rather than install), but right now the cmake packages are not released officially anywhere (the nightly build only releases the make builds) and this would not be useful for the same reasons as on Windows.

@yuxiaomao yuxiaomao merged commit 98addf9 into HaxeFoundation:master Sep 9, 2024
8 checks passed
@tobil4sk tobil4sk deleted the fix/cmake-install-windows branch September 9, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants